Messages in this thread | | | Date | Tue, 11 Oct 2022 14:03:42 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH v2] riscv: always honor the CONFIG_CMDLINE_FORCE when parsing dtb |
| |
On Mon, Oct 10, 2022 at 05:10:33PM +0200, Björn Töpel wrote: > Wenting Zhang <zephray@outlook.com> writes: > > > When CONFIG_CMDLINE_FORCE is enabled, cmdline provided by > > CONFIG_CMDLINE are always used. This allows CONFIG_CMDLINE to be > > used regardless of the result of device tree scanning. > > > > This especially fixes the case where a device tree without the > > chosen node is supplied to the kernel. In such cases, > > early_init_dt_scan would return true. But inside > > early_init_dt_scan_chosen, the cmdline won't be updated as there > > is no chosen node in the device tree. As a result, CONFIG_CMDLINE > > is not copied into boot_command_line even if CONFIG_CMDLINE_FORCE > > is enabled. This commit allows properly update boot_command_line > > in this situation. > > > > Fixes: 8fd6e05c7463 ("arch: riscv: support kernel command line forcing when no DTB passed") > > Signed-off-by: Wenting Zhang <zephray@outlook.com> > > Reviewed-by: Björn Töpel <bjorn@kernel.org>
I noticed that the version of this patch that I had left un-archived in patchwork was not the correct one. I then realised I gave a "LGTM" type thing in reponse to the v1, about the v2 but nothing on v2 itself.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks, Conor.
| |