Messages in this thread | | | Date | Tue, 11 Oct 2022 12:06:15 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 25/36] pinctrl: starfive: Add missed header(s) |
| |
On Tue, Oct 11, 2022 at 10:31:33AM +0200, Emil Renner Berthing wrote: > On Mon, 10 Oct 2022 at 22:26, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > Do not imply that some of the generic headers may be always included. > > Instead, include explicitly what we are direct user of. > > > > While at it, sort headers alphabetically. > > The patch is fine, but I don't see any sorting other than just adding > the headers at the appropriate place.
I will amend commit message here.
> In any case > > Acked-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
Thank you!
-- With Best Regards, Andy Shevchenko
| |