Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 11 Oct 2022 10:58:19 +0300 | Subject | Re: [PATCH v2 12/36] pinctrl: k210: Add missed header(s) |
| |
On Tue, Oct 11, 2022 at 1:33 AM Damien Le Moal <Damien.LeMoal@wdc.com> wrote: > On 2022/10/11 5:15, Andy Shevchenko wrote: > > Do not imply that some of the generic headers may be always included. > > Instead, include explicitly what we are direct user of. > > > > While at it, sort headers alphabetically. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Looks OK to me, but the patch title should be: > > pinctrl: k210: Add missing header(s) > > Same remark for the entire series. You need s/missed/missing in all patch titles.
Oh, the missing word 'missing' :-) I will replace it locally (I won't resend it because of that).
> With that fixed, > > Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Thanks!
-- With Best Regards, Andy Shevchenko
| |