lkml.org 
[lkml]   [2022]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fs/select: mark do_select noinline_for_stack for 32b
    On Fri, Oct 7, 2022, at 10:11 PM, Nick Desaulniers wrote:
    > +#ifdef CONFIG_64BIT
    > +#define noinline_for_stack_32b
    > +#else
    > +#define noinline_for_stack_32b noinline_for_stack
    > +#endif
    > +
    > +noinline_for_stack_32b

    I don't see much value in making it behave differently for 32 bit:
    it doesn't reduce the total frame size on 32-bit machines but only
    hides the warning. The bug you are working around also looks i386
    specific (because of limited number of registers vs ubsan needing
    a lot of them), so just make it a simple 'noinline_for_stack'.

    Arnd

    \
     
     \ /
      Last update: 2022-10-10 21:57    [W:4.248 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site