Messages in this thread | | | Date | Mon, 10 Oct 2022 21:55:47 +0200 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH] fs/select: mark do_select noinline_for_stack for 32b |
| |
On Fri, Oct 7, 2022, at 10:11 PM, Nick Desaulniers wrote: > +#ifdef CONFIG_64BIT > +#define noinline_for_stack_32b > +#else > +#define noinline_for_stack_32b noinline_for_stack > +#endif > + > +noinline_for_stack_32b
I don't see much value in making it behave differently for 32 bit: it doesn't reduce the total frame size on 32-bit machines but only hides the warning. The bug you are working around also looks i386 specific (because of limited number of registers vs ubsan needing a lot of them), so just make it a simple 'noinline_for_stack'.
Arnd
| |