Messages in this thread | | | Date | Mon, 10 Oct 2022 17:05:47 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH v2 1/2] ARM: Fix some check warnings of tool sparse |
| |
On Mon, Oct 10, 2022 at 05:53:45PM +0800, Zhen Lei wrote: > Fix the following warnings: > warning: incorrect type in initializer (different address spaces) > expected unsigned short [noderef] __user *register __p > got unsigned short [usertype] * > warning: cast removes address space '__user' of expression
I have a general principle that not all warnings should be fixed, especially when it comes to sparse.
The aim is not to get to zero warnings - it's to get to a point where the code is correct, and plastering the code with __force casts means it isn't correct - you're just masking the warning.
So no, I really don't like this. And I really don't like seeing __force being used in open code in casts.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| |