lkml.org 
[lkml]   [2022]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 0/4] fs/ntfs3: Fix and rename hidedotfiles mount option
From
Às 09:08 de 09/10/22, Kari Argillander escreveu:
> On Fri, 7 Oct 2022 at 15:32, Daniel Pinto <danielpinto52@gmail.com> wrote:
>>
>> The current implementation of the hidedotfiles has some problems, namely:
>> - there is a bug where enabling it actually disables it and vice versa
>> - it only works when creating files, not when moving or renaming them
>> - is is not listed in the enabled options list by the mount command
>> - its name differs from the equivalent hide_dot_files mount option
>> used by NTFS-3G, making it incompatible with it for no reason
>>
>> This series of patches tries to fix those problems.
>
> While you are fixing this can you also make patch to add documentation
> for this mount option. I also think we really should not make new mount
> option names so I would vote hide_dot_files name as you did. We still have
> time for this change as this is not yet in upstream.
>

I have submitted a v2 of the patch which includes a commit with the
documentation.

>> Daniel Pinto (4):
>> fs/ntfs3: fix hidedotfiles mount option by reversing behaviour
>> fs/ntfs3: make hidedotfiles mount option work when renaming files
>> fs/ntfs3: add hidedotfiles to the list of enabled mount options
>> fs/ntfs3: rename hidedotfiles mount option to hide_dot_files
>>
>> fs/ntfs3/frecord.c | 9 +++++++++
>> fs/ntfs3/inode.c | 2 +-
>> fs/ntfs3/super.c | 6 ++++--
>> 3 files changed, 14 insertions(+), 3 deletions(-)
>>
>

\
 
 \ /
  Last update: 2022-10-10 13:51    [W:0.077 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site