lkml.org 
[lkml]   [2022]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 34/40] arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema
From
On 10/10/2022 06:26, Krzysztof Kozlowski wrote:
> On 09/10/2022 13:46, Marijn Suijten wrote:
>>> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
>>> index 8c582a9e4ada..1fe3fa3ad877 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
>>> @@ -387,19 +387,19 @@ tlmm: pinctrl@500000 {
>>> #interrupt-cells = <2>;
>>>
>>> sdc2_off_state: sdc2-off-state {
>>> - clk {
>>> + clk-pins {
>>> pins = "sdc2_clk";
>>> drive-strength = <2>;
>>> bias-disable;
>>> };
>>>
>>> - cmd {
>>> + cmd-pins {
>>> pins = "sdc2_cmd";
>>> drive-strength = <2>;
>>> bias-pull-up;
>>> };
>>>
>>> - data {
>>> + data-pins {
>>> pins = "sdc2_data";
>>> drive-strength = <2>;
>>> bias-pull-up;
>>> @@ -413,13 +413,13 @@ clk {
>>> bias-disable;
>>> };
>>>
>>> - cmd {
>>> + cmd-pins-pins {
>>
>> Is this double -pins-pins suffix intended?
>>
>
> No, thanks for noticing it.

Wait, you commented on patch which was already merged. Fix is here already:
https://lore.kernel.org/linux-devicetree/20220930192954.242546-11-krzysztof.kozlowski@linaro.org/

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-10-10 13:32    [W:0.121 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site