Messages in this thread Patch in this message | | | From | INAGAKI Hiroshi <> | Subject | [PATCH] nvmem: u-boot-env: align endianness of crc32 values | Date | Tue, 11 Oct 2022 11:49:28 +0900 |
| |
This patch fixes crc32 error on Big-Endianness system by conversion of calculated crc32 value.
Little-Endianness system:
obtained crc32: Little calculated crc32: Little
Big-Endianness system:
obtained crc32: Little calculated crc32: Big
log (APRESIA ApresiaLightGS120GT-SS, RTL8382M, Big-Endianness):
[ 8.570000] u_boot_env 18001200.spi:flash@0:partitions:partition@c0000: Invalid calculated CRC32: 0x88cd6f09 (expected: 0x096fcd88) [ 8.580000] u_boot_env: probe of 18001200.spi:flash@0:partitions:partition@c0000 failed with error -22
Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com> --- drivers/nvmem/u-boot-env.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvmem/u-boot-env.c b/drivers/nvmem/u-boot-env.c index 8e72d1bbd649..983dc2312af2 100644 --- a/drivers/nvmem/u-boot-env.c +++ b/drivers/nvmem/u-boot-env.c @@ -143,7 +143,7 @@ static int u_boot_env_parse(struct u_boot_env *priv) crc32_data_len = priv->mtd->size - crc32_data_offset; data_len = priv->mtd->size - data_offset; - calc = crc32(~0, buf + crc32_data_offset, crc32_data_len) ^ ~0L; + calc = le32_to_cpu(crc32(~0, buf + crc32_data_offset, crc32_data_len) ^ ~0L); if (calc != crc32) { dev_err(dev, "Invalid calculated CRC32: 0x%08x (expected: 0x%08x)\n", calc, crc32); err = -EINVAL; -- 2.25.1
| |