Messages in this thread | | | Subject | Re: [PATCH 1/4] blk-cgroup: Remove unnecessary blk_ioprio_exit in blkcg_init_queue | From | Kemeng Shi <> | Date | Tue, 11 Oct 2022 09:04:35 +0800 |
| |
on 10/10/2022 3:37 PM, Christoph Hellwig wrote: > On Mon, Oct 10, 2022 at 10:38:56AM +0800, Kemeng Shi wrote: >> Function blk_ioprio_init only alloc blkg_policy_data which will be freed >> in blkg_destroy_all, so no blk_ioprio_exit is called when blk_throtl_init >> is failed in blkcg_init_queue. Also blk_ioprio_exit is not called in >> blkcg_exit_queue for the same reason. Just remove blk_ioprio_exit to >> keep behavior consistent. > > This code looks very different in current mainline. Thanks for review. I will remove this patch and make new patches based on mainline code. -- Best wishes Kemeng Shi
| |