lkml.org 
[lkml]   [2022]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: Unloaded tainted modules list with tcrypt
    Date


    > -----Original Message-----
    > From: Elliott, Robert (Servers) <elliott@hpe.com>
    > Sent: Monday, October 10, 2022 10:12 AM
    > To: Aaron Tomlin <atomlin@redhat.com>; linux-modules@vger.kernel.org; linux-
    > kernel@vger.kernel.org
    > Subject: Unloaded tainted modules list with tcrypt
    >
    > When repeatedly using the tcrypt module (which is designed to never
    > load successfully), the "Unloaded tainted modules" list grows forever:
    >
    > Unloaded tainted modules: tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
    > tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
    > tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
    > tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
    > tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
    > tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
    > tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
    > tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
    > tcrypt():1 tcrypt():1 padlock_aes():1 padlock_aes():1
    > isst_if_mbox_msr():1 acpi_cpufreq():1 pcc_cpufreq():1 isst_if_mbox_msr():1
    > acpi_cpufreq():1 pcc_cpufreq():1 acpi_cpufreq():1 acpi_cpufreq():1
    > pcc_cpufreq():1 isst_if_mbox_msr():1 acpi_cpufreq():1 acpi_cpufreq():1
    > pcc_cpufreq():1 isst_if_mbox_msr():1 acpi_cpufreq():1 acpi_cpufreq():1
    > isst_if_mbox_msr():1 isst_if_mbox_msr():1
    > acpi_cpufreq():1 pcc_cpufreq():1 acpi_cpufreq():1 isst_if_mbox_msr():1
    >
    > Some other modules like acpi_cpufreq() are repeated too.
    >
    > Maybe this check after the name comparison:
    > mod_taint->taints & mod->taints
    > should be:
    > mod_taint->taints == mod->taints
    >
    > or shouldn't be there at all?

    Changing to == seems to work well - that shows incremented counts
    rather than new entries:
    Unloaded tainted modules: tcrypt():40 padlock_aes():1 isst_if_mbox_msr():56 pcc_cpufreq():56 acpi_cpufreq():112


    \
     
     \ /
      Last update: 2022-10-11 02:11    [W:2.732 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site