lkml.org 
[lkml]   [2022]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] Documentation/process: Add text to indicate supporters should be mailed
From
On 01/10/2022 03:37, Theodore Ts'o wrote:
> FWIW, I actually think the output of get_maintainer.pl is pretty
> broken in this regard. (Then again, I've never thought all that
> highly of get_maintainer.pl,*especially* because of the bogus git
> fallback, but that's another story.)
>
> Consider:
>
> % ./scripts/get_maintainer.pl --file drivers/acpi/power.c
> "Rafael J. Wysocki"<rafael@kernel.org> (supporter:ACPI)
> Len Brown<lenb@kernel.org> (reviewer:ACPI)
> linux-acpi@vger.kernel.org (open list:ACPI)
> linux-kernel@vger.kernel.org (open list)
>
> I'm sorry, but that's just*wrong*. Rafael is the*maintainer* of the
> ACPI subsystem, and the term "supporter" is rarely if ever used
> anywhere in our docs. As I said earlier, trying to treat S: field to
> say anything about the entitles listed under the M: field of the
> Maintainers file is a category error.

I agree, I made exactly this error.

I wasn't sure how people would necessarily feel about having
get_maintainer produce the string 'maintainer' for both Maintained and
Supported but, IMO it is more consistent to have it do so, since we
refer to maintainers all throughout the doucmentation and as you say
above Rafael is the person you *need* to mail there because he's the
maintainer.

Lets consider

- maintainer as a string for "S: Supported"
- Documentation update to reflect Krzysztof's point on git-fallback

---
bod

\
 
 \ /
  Last update: 2022-10-01 12:38    [W:0.078 / U:2.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site