lkml.org 
[lkml]   [2022]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] net: lantiq_etop: make alignment match open parenthesis
From
Hi Joe,

On 12/30/21 02:32, Joe Perches wrote:
> On Thu, 2021-12-30 at 00:39 +0100, Aleksander Jan Bajkowski wrote:
>> checkpatch.pl complains as the following:
>>
>> Alignment should match open parenthesis
> []
>> diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
> []
>> @@ -111,9 +111,9 @@ ltq_etop_alloc_skb(struct ltq_etop_chan *ch)
>> ch->skb[ch->dma.desc] = netdev_alloc_skb(ch->netdev, MAX_DMA_DATA_LEN);
>> if (!ch->skb[ch->dma.desc])
>> return -ENOMEM;
>> - ch->dma.desc_base[ch->dma.desc].addr = dma_map_single(&priv->pdev->dev,
>> - ch->skb[ch->dma.desc]->data, MAX_DMA_DATA_LEN,
>> - DMA_FROM_DEVICE);
>> + ch->dma.desc_base[ch->dma.desc].addr =
>> + dma_map_single(&priv->pdev->dev, ch->skb[ch->dma.desc]->data,
>> + MAX_DMA_DATA_LEN, DMA_FROM_DEVICE);
>> ch->dma.desc_base[ch->dma.desc].addr =
>> CPHYSADDR(ch->skb[ch->dma.desc]->data);
>
> Unassociated trivia:
>
> ch->dma.desc_base[ch->dma.desc].addr is the target of consecutive assignments.
>
> That looks very odd.
>
> Isn't the compiler allowed to toss/throw away the first assignment?
>
>


I think you are right. This function should look similar to xrx200_alloc_skb().
Both drivers have the same DMA IP core and packet receiving mechanism.

\
 
 \ /
  Last update: 2022-01-08 16:48    [W:0.071 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site