lkml.org 
[lkml]   [2022]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] notifier/panic: Introduce panic_notifier_filter
From
On 07/01/2022 20:07, Andy Shevchenko wrote:
> [...]
> +       if (!buf)
> +               return -EINVAL;
>
>
> I also implied that you don’t need this condition.
>
> +       while ((func = strsep(&buf, ","))) {
> +               addr = kallsyms_lookup_name(func);
>
>  
>
> +
>
>
> Btw, this is redundant blank line.
>  
>
> +               if (!addr) {

Thanks Andy, just submitted a V4 that incorporates your suggestions.
Cheers,


Guilherme

\
 
 \ /
  Last update: 2022-01-08 16:37    [W:0.028 / U:1.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site