lkml.org 
[lkml]   [2022]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 3/8] rtw88: Use rtw_iterate_vifs where the iterator reads or writes registers
    Date
    Upcoming SDIO support may sleep in the read/write handlers. Switch
    all users of rtw_iterate_vifs_atomic() which are either reading or
    writing a register to rtw_iterate_vifs().

    Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
    ---
    drivers/net/wireless/realtek/rtw88/main.c | 2 +-
    drivers/net/wireless/realtek/rtw88/ps.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
    index fd02c0b0025a..b0e2ca8ddbe9 100644
    --- a/drivers/net/wireless/realtek/rtw88/main.c
    +++ b/drivers/net/wireless/realtek/rtw88/main.c
    @@ -585,7 +585,7 @@ static void __fw_recovery_work(struct rtw_dev *rtwdev)
    rtw_iterate_keys_rcu(rtwdev, NULL, rtw_reset_key_iter, rtwdev);
    rcu_read_unlock();
    rtw_iterate_stas_atomic(rtwdev, rtw_reset_sta_iter, rtwdev);
    - rtw_iterate_vifs_atomic(rtwdev, rtw_reset_vif_iter, rtwdev);
    + rtw_iterate_vifs(rtwdev, rtw_reset_vif_iter, rtwdev);
    rtw_enter_ips(rtwdev);
    }

    diff --git a/drivers/net/wireless/realtek/rtw88/ps.c b/drivers/net/wireless/realtek/rtw88/ps.c
    index bfa64c038f5f..a7213ff2c224 100644
    --- a/drivers/net/wireless/realtek/rtw88/ps.c
    +++ b/drivers/net/wireless/realtek/rtw88/ps.c
    @@ -58,7 +58,7 @@ int rtw_leave_ips(struct rtw_dev *rtwdev)
    return ret;
    }

    - rtw_iterate_vifs_atomic(rtwdev, rtw_restore_port_cfg_iter, rtwdev);
    + rtw_iterate_vifs(rtwdev, rtw_restore_port_cfg_iter, rtwdev);

    rtw_coex_ips_notify(rtwdev, COEX_IPS_LEAVE);

    --
    2.34.1
    \
     
     \ /
      Last update: 2022-01-08 01:56    [W:6.409 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site