Messages in this thread | | | Subject | Re: [PATCH] clk: visconti: Remove pointless NULL check in visconti_pll_add_lookup() | From | Stephen Boyd <> | Date | Fri, 07 Jan 2022 16:08:10 -0800 |
| |
Quoting Nathan Chancellor (2022-01-07 10:33:03) > Clang warns: > > drivers/clk/visconti/pll.c:292:20: warning: address of array 'ctx->clk_data.hws' will always evaluate to 'true' [-Wpointer-bool-conversion] > if (ctx->clk_data.hws && id) > ~~~~~~~~~~~~~~^~~ ~~ > 1 warning generated. > > This array cannot be NULL if ctx is not NULL, which is allocated in > visconti_init_pll(), so just remove the check, which matches other clk > drivers. > > Fixes: b4cbe606dc36 ("clk: visconti: Add support common clock driver and reset driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/1564 > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > ---
Applied to clk-next
| |