Messages in this thread | | | From | Stephen Boyd <> | Date | Fri, 7 Jan 2022 15:13:57 -0800 | Subject | Re: [PATCH] HID: vivaldi: fix handling devices not using numbered reports |
| |
Quoting Dmitry Torokhov (2022-01-07 12:09:36) > Unfortunately details of USB HID transport bled into HID core and > handling of numbered/unnumbered reports is quite a mess, with > hid_report_len() calculating the length according to USB rules, > and hid_hw_raw_request() adding report ID to the buffer for both > numbered and unnumbered reports. > > Untangling it all requres a lot of changes in HID, so for now let's > handle this in the driver. > > Fixes: 14c9c014babe ("HID: add vivaldi HID driver") > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > ---
This silences a warning I see printed from this driver
hid-vivaldi 0003:18D1:504C.0002: failed to fetch feature 0
and then I see the 'function_row_physmap' attribute in sysfs is non-zero now. Thanks!
Tested-by: Stephen Boyd <swboyd@chromium.org> # CoachZ
| |