Messages in this thread | | | Date | Fri, 7 Jan 2022 08:22:41 +0100 | From | Miquel Raynal <> | Subject | Re: [PATCH v2 2/9] mtd: rawnand: brcmnand: Allow SoC to provide I/O operations |
| |
Hi Florian,
f.fainelli@gmail.com wrote on Thu, 6 Jan 2022 19:10:12 -0800:
> On 1/6/2022 4:13 PM, Florian Fainelli wrote: > > Allow a brcmnand_soc instance to provide a custom set of I/O operations > > which we will require when using this driver on a BCMA bus which is not > > directly memory mapped I/O. Update the nand_{read,write}_reg accordingly > > to use the SoC operations if provided. > > > > To minimize the penalty on other SoCs which do support standard MMIO > > accesses, we use a static key which is disabled by default and gets > > enabled if a soc implementation does provide I/O operations. > > > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > > --- > > [snip] > > > init_completion(&ctrl->done); > > init_completion(&ctrl->dma_done); > > init_completion(&ctrl->edu_done); > > @@ -3145,6 +3169,8 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc) > > /* Enable interrupt */ > > ctrl->soc->ctlrdy_ack(ctrl->soc); > > ctrl->soc->ctlrdy_set_enabled(ctrl->soc, true); > > + if (brcmnand_soc_has_ops(soc)) > > + static_branch_enable(&brcmnand_soc_has_ops_key); > > This hunk got mistakenly added with a rebase, I will wait for additional comments before spinning a new version.
FYI the series LGTM otherwise.
Thanks, Miquèl
| |