Messages in this thread | | | Date | Fri, 7 Jan 2022 16:57:39 +0800 | Subject | Re: [PATCH v3 2/6] crypto: arm64/sm3-ce - make dependent on sm3 library | From | Tianjia Zhang <> |
| |
Hi Herbert,
On 1/7/22 11:28 AM, Herbert Xu wrote: > On Thu, Dec 23, 2021 at 12:35:43PM +0800, Tianjia Zhang wrote: >> SM3 generic library is stand-alone implementation, sm3-ce can depend >> on the SM3 library instead of sm3-generic. >> >> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> >> --- >> arch/arm64/crypto/Kconfig | 2 +- >> arch/arm64/crypto/sm3-ce-glue.c | 20 ++++++++++++++------ >> 2 files changed, 15 insertions(+), 7 deletions(-) > > This doesn't compile cleanly with C=1 W=1: > > CC [M] arch/arm64/crypto/sm3-ce-glue.o > AS [M] arch/arm64/crypto/sm3-ce-core.o > CC [M] arch/arm64/crypto/sm4-ce-glue.o > CHECK ../arch/arm64/crypto/sha3-ce-glue.c > ../arch/arm64/crypto/sm3-ce-glue.c: In function ‘sm3_ce_update’: > ../arch/arm64/crypto/sm3-ce-glue.c:30:10: error: void value not ignored as it ought to be > 30 | return sm3_update(shash_desc_ctx(desc), data, len); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../arch/arm64/crypto/sm3-ce-glue.c: In function ‘sm3_ce_final’: > ../arch/arm64/crypto/sm3-ce-glue.c:42:10: error: void value not ignored as it ought to be > 42 | return sm3_final(shash_desc_ctx(desc), out); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > make[3]: *** [../scripts/Makefile.build:287: arch/arm64/crypto/sm3-ce-glue.o] Error 1 > make[3]: *** Waiting for unfinished jobs.... > > Please make sure everything builds cleanly with C=1 W=1 *before* > you submit. > > Thanks,
Thanks for pointing it out, will fix it in next patch. There will never be such a low-level error in the future
Kind Regards, Tianjia
| |