Messages in this thread | | | Date | Thu, 6 Jan 2022 17:16:27 -0700 | From | Nathan Chancellor <> | Subject | Re: [PATCH 0/2] *** Fix reformat_objdump.awk *** |
| |
On Fri, Jan 07, 2022 at 10:23:07AM +1100, Samuel Zeter wrote: > Thanks for the feedback, Nathan. > > > For the future, I recommend putting the maintainers in the "To" field, > > rather than "Cc", to ensure they actually see it. Additionally, I see > > some small nits in the commit message that the tip maintainers might > > comment on, see > > > > https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#changelog > > > Thanks for the link, I missed that one. What were the nits apparent to you > in the commit message?
I primarily just saw a couple instances of "This patch", which is frowned upon in the main submitting patches document:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#submittingpatches
I thought I saw something else but upon further inspection, I didn't. It is minor enough that I would wait for further review comments from others to submit a v2.
Cheers, Nathan
| |