Messages in this thread | | | Date | Thu, 6 Jan 2022 15:54:17 -0800 | Subject | Re: [PATCH v2 5/5] selftests/resctrl: Return KSFT_SKIP(4) if resctrlfile system is not supported or resctrl is not run as root | From | Reinette Chatre <> |
| |
Hi Shaopeng Tan,
Subject line still with typo. Also, what does "resctrl is not run as root" mean? Do you mean "resctrl_tests"? The subject line can be made more succinct while the details are moved to the commit message.
On 12/13/2021 2:01 AM, Shaopeng Tan wrote: > To unify the return code of resctrl_tests with the return code of > selftest set, return KSFT_SKIP (4) if resctrl file system is not > supported or resctrl is not run as root.
Please review the feedback I provided to your first version. I do not see the explanation of how changing ksft_exit_fail_msg() to ksft_exit_skip() accomplishes the goal of unifying the return code. It surely is not a good use of my time to review patches and have the feedback ignored.
> > Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> > --- > tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c > index 973f09a66e1e..3be0895c492b 100644 > --- a/tools/testing/selftests/resctrl/resctrl_tests.c > +++ b/tools/testing/selftests/resctrl/resctrl_tests.c > @@ -205,7 +205,7 @@ int main(int argc, char **argv) > * 2. We execute perf commands > */ > if (geteuid() != 0) > - return ksft_exit_fail_msg("Not running as root, abort testing.\n"); > + return ksft_exit_skip("Not running as root, abort testing.\n"); > > /* Detect AMD vendor */ > detect_amd(); > @@ -235,7 +235,7 @@ int main(int argc, char **argv) > sprintf(bm_type, "fill_buf"); > > if (!check_resctrlfs_support()) > - return ksft_exit_fail_msg("resctrl FS does not exist\n"); > + return ksft_exit_skip("resctrl FS does not exist\n"); > > filter_dmesg(); >
Reinette
| |