Messages in this thread Patch in this message | | | Date | Thu, 6 Jan 2022 21:03:44 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH] lib: remove redundant assignment to variable ret |
| |
On Thu, Dec 30, 2021 at 01:45:57PM +0000, Colin Ian King wrote: > Variable ret is being assigned a value that is never read. If the > for-loop is entered then ret is immediately re-assigned a new > value. If the for-loop is not executed ret is never read. The > assignment is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
> --- > lib/asn1_encoder.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/asn1_encoder.c b/lib/asn1_encoder.c > index 27bbe891714f..0fd3c454a468 100644 > --- a/lib/asn1_encoder.c > +++ b/lib/asn1_encoder.c > @@ -164,8 +164,6 @@ asn1_encode_oid(unsigned char *data, const unsigned char *end_data, > > data_len -= 3; > > - ret = 0; > - > for (i = 2; i < oid_len; i++) { > ret = asn1_encode_oid_digit(&d, &data_len, oid[i]); > if (ret < 0) > -- > 2.33.1 >
| |