Messages in this thread | | | Date | Thu, 6 Jan 2022 15:26:07 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 20/32] staging: r8188eu: make odm_RefreshRateAdaptiveMask() static |
| |
On Wed, Dec 29, 2021 at 09:50:56PM +0100, Michael Straube wrote: > +static void odm_RefreshRateAdaptiveMask(struct odm_dm_struct *pDM_Odm) > +{ > + u8 i; > + struct adapter *pAdapter = pDM_Odm->Adapter; > + > + if (pAdapter->bDriverStopped) > + return; > + > + for (i = 0; i < ODM_ASSOCIATE_ENTRY_NUM; i++) { > + struct sta_info *pstat = pDM_Odm->pODM_StaInfo[i]; > +
Michael, people don't thank you enough for all the clean up work on this driver. This is not a "please resend" level issue, and also Greg already applied the patch so resending is impossible.
But, you added a blank line here after the declaration to make checkpatch happy. When you're moving functions around could you just leave them exactly as-is? I have a script to help me review moving code and it helps me if the functions stay exactly the same.
Anyway, thanks again for your cleanup work on this driver.
> + if (IS_STA_VALID(pstat)) { > + if (ODM_RAStateCheck(pDM_Odm, pstat->rssi_stat.UndecoratedSmoothedPWDB, false, &pstat->rssi_level)) > + rtw_hal_update_ra_mask(pAdapter, i, pstat->rssi_level); > + } > + } > +}
regards, dan carpenter
| |