Messages in this thread | | | Date | Thu, 6 Jan 2022 11:40:34 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] regulator: Add MAX20086-MAX20089 driver |
| |
On Thu, Jan 06, 2022 at 01:23:07AM +0200, Laurent Pinchart wrote: > On Tue, Jan 04, 2022 at 04:33:54PM +0200, Laurent Pinchart wrote: > > On Tue, Jan 04, 2022 at 02:16:33PM +0000, Mark Brown wrote:
> > > It is worrying that a regulator driver should need the interfaces for > > > machines... the driver doesn't look like it actually does though.
> > I'll try to remove it.
> It compiles fine, but I won't be able to check the init data to figure > out the initial enable GPIO state if I don't include machine.h, as > that's where regulator_init_data is defined. Am I missing something ?
Right, forgot about that bit - it's more of an issue with the gpiod conversion. You could just request always enabled but it's probably fine to leave as is with looking at but not modifying the constraints.
> > > > +static const struct regmap_config max20086_regmap_config = { > > > > + .reg_bits = 8, > > > > + .val_bits = 8, > > > > + .writeable_reg = max20086_gen_is_writeable_reg, > > > > + .max_register = 0x9, > > > > + .cache_type = REGCACHE_NONE, > > > > +};
> > > No readback support?
> > I'll fix that.
> Actually I'm not sure what you mean here. All registers are readable, > what's wrong with the above regmap_config ?
It's not *wrong* if that's the case, it just looks weird to only provide writable but not readable. [unhandled content-type:application/pgp-signature] | |