lkml.org 
[lkml]   [2022]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing: check the return value of kstrndup()
Masami, can you ack this?

-- Steve


On Tue, 14 Dec 2021 10:26:46 +0800
xkernel.wang@foxmail.com wrote:

> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> kstrndup() is a memory allocation-related function, it returns NULL when
> some internal memory errors happen. It is better to check the return
> value of it so to catch the memory error in time.
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
> kernel/trace/trace_probe.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> index 3ed2a3f..bb4605b 100644
> --- a/kernel/trace/trace_probe.c
> +++ b/kernel/trace/trace_probe.c
> @@ -356,6 +356,8 @@ static int __parse_imm_string(char *str, char **pbuf, int offs)
> return -EINVAL;
> }
> *pbuf = kstrndup(str, len - 1, GFP_KERNEL);
> + if (!*pbuf)
> + return -ENOMEM;
> return 0;
> }
>

\
 
 \ /
  Last update: 2022-01-05 23:13    [W:0.027 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site