Messages in this thread | | | From | Brian Norris <> | Date | Wed, 5 Jan 2022 11:55:05 -0800 | Subject | Re: [PATCH v2] drm/bridge: analogix_dp: Grab runtime PM reference for DP-AUX |
| |
(updating Andrzej's email)
On Fri, Oct 1, 2021 at 2:50 PM Brian Norris <briannorris@chromium.org> wrote: > If the display is not enable()d, then we aren't holding a runtime PM > reference here. Thus, it's easy to accidentally cause a hang, if user > space is poking around at /dev/drm_dp_aux0 at the "wrong" time. > > Let's get the panel and PM state right before trying to talk AUX. > > Fixes: 0d97ad03f422 ("drm/bridge: analogix_dp: Remove duplicated code") > Cc: <stable@vger.kernel.org> > Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com> > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > > Changes in v2: > - Fix spelling in Subject > - DRM_DEV_ERROR() -> drm_err() > - Propagate errors from un-analogix_dp_prepare_panel() > > .../drm/bridge/analogix/analogix_dp_core.c | 21 ++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-)
Ping? Do I need to do anything more here?
Thanks, Brian
| |