Messages in this thread | | | Subject | Re: [PATCH] sh: sq: use default_groups in kobj_type | From | Rob Landley <> | Date | Wed, 5 Jan 2022 12:11:25 -0600 |
| |
On 1/5/22 11:52 AM, Greg Kroah-Hartman wrote: > On Wed, Jan 05, 2022 at 11:46:28AM -0600, Rob Landley wrote: >> On 1/4/22 10:22 AM, Greg Kroah-Hartman wrote: >> > There are currently 2 ways to create a set of sysfs files for a >> > kobj_type, through the default_attrs field, and the default_groups >> > field. Move the sh sq sysfs code to use default_groups field which has >> > been the preferred way since aa30f47cf666 ("kobject: Add support for >> > default attribute groups to kobj_type") so that we can soon get rid of >> > the obsolete default_attrs field. >> >> Let's see, sh4-specific, depends on CONFIG_SH_STORE_QUEUES... it built but I'm >> not finding an "sq" entry under /proc. (Or anything with "mapping" in it...) >> >> Oh well, probably right? Didn't break anything for me: >> >> Tested-by: Rob Landley <rob@landley.net> > > Thanks! Seems to pass 0-day testing as well :) > > Should I take this in my tree?
Yes please.
Rob
| |