Messages in this thread | | | From | Robert Foss <> | Date | Wed, 5 Jan 2022 18:41:09 +0100 | Subject | Re: [PATCH] drm/bridge: Add missing pm_runtime_disable() in __dw_mipi_dsi_probe |
| |
Hey,
Thanks for submitting this fix.
On Wed, 5 Jan 2022 at 11:41, Miaoqian Lin <linmq006@gmail.com> wrote: > > If the probe fails, we should use pm_runtime_disable() to balance > pm_runtime_enable(). > Add missing pm_runtime_disable() for __dw_mipi_dsi_probe. > > Fixes: 46fc515 ("drm/bridge/synopsys: Add MIPI DSI host controller bridge") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > index e44e18a0112a..56c3fd08c6a0 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > @@ -1199,6 +1199,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev, > ret = mipi_dsi_host_register(&dsi->dsi_host); > if (ret) { > dev_err(dev, "Failed to register MIPI host: %d\n", ret); > + pm_runtime_disable(dev); > dw_mipi_dsi_debugfs_remove(dsi); > return ERR_PTR(ret); > } > -- > 2.17.1 >
Added r-b tag and applied to drm-misc-next
Reviewed-by: Robert Foss <robert.foss@linaro.org>
| |