lkml.org 
[lkml]   [2022]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers/hwmon: remove redundant res variable
From
Date
On 1/4/22 3:28 AM, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value from inb_p() directly instead
> of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>

Please do not send me such patches. The subject starts with the wrong tag
(it should have been "hwmon: (nct6683)", it is misleading (the variable is
not redundant; if anything it is unnecessary), and the patch itself adds
zero value. The submitter may have had a reason for using a variable,
may it be personal style or ease of adding a debug statement when testing.
There is no valid reason for changing such code.

Guenter

> ---
> drivers/hwmon/nct6683.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
> index 6a9f420e7d32..ab02e967f73d 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -495,13 +495,10 @@ static inline long in_from_reg(u16 reg, u8 src)
>
> static u16 nct6683_read(struct nct6683_data *data, u16 reg)
> {
> - int res;
> -
> outb_p(0xff, data->addr + EC_PAGE_REG); /* unlock */
> outb_p(reg >> 8, data->addr + EC_PAGE_REG);
> outb_p(reg & 0xff, data->addr + EC_INDEX_REG);
> - res = inb_p(data->addr + EC_DATA_REG);
> - return res;
> + return inb_p(data->addr + EC_DATA_REG);
> }
>
> static u16 nct6683_read16(struct nct6683_data *data, u16 reg)
>

\
 
 \ /
  Last update: 2022-01-05 16:49    [W:0.033 / U:2.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site