lkml.org 
[lkml]   [2022]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: gyro: bmg160: Fix error handling in bmg160_core_probe
On Wed, Jan 05, 2022 at 01:07:43PM +0000, Jonathan Cameron wrote:
> On Wed, 5 Jan 2022 12:56:30 +0000
> Miaoqian Lin <linmq006@gmail.com> wrote:
>
> > The pm_runtime_enable will increase power disable depth.
> > If the probe fails, we should use pm_runtime_disable() to balance
> > pm_runtime_enable(). In the PM Runtime docs:
> > Drivers in ->remove() callback should undo the runtime PM changes done
> > in ->probe(). Usually this means calling pm_runtime_disable(),
> > pm_runtime_dont_use_autosuspend() etc.
> > We should do this in error handling.
> >
> > Fixes: 7d0ead5 ("iio: Reconcile operation order between iio_register/unregister and pm functions")
>
> Hi Miaoqian,
>
> Please check this fixes tag against the format it should have.

I usually advise people to put the following in the ~/.gitconfig:

[core]
abbrev = 12

[alias]
one = show -s --pretty='format:%h (\"%s\")'
c = show -s --pretty='format:https://git.kernel.org/torvalds/c/%h'

`git one ...` will give a right thing.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2022-01-05 15:21    [W:0.352 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site