Messages in this thread | | | Date | Wed, 5 Jan 2022 12:17:38 +0200 | From | Mika Westerberg <> | Subject | Re: [PATCH] thunderbolt: Check for null pointer after calling kmemdup in icm_handle_event |
| |
Hi,
On Wed, Jan 05, 2022 at 04:26:34PM +0800, Jiasheng Jiang wrote: > As the possible failure of the allocation, kmemdup() may return NULL > pointer. > Like alloc_switch(), it might be better to check it. > Therefore, icm_handle_event() should also check the return value of > kmemdup(). > If fails, just free 'n' and directly return is enough, same as the way > to handle the failure of kmalloc(). > > Fixes: f67cf491175a ("thunderbolt: Add support for Internal Connection Manager (ICM)") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Thanks for the patch but I realized that this has been fixed already:
https://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git/commit/?h=next&id=3cc1c6de458e0e58c413c3c35802ca96e55bbdbe
| |