Messages in this thread Patch in this message | | | Date | Wed, 5 Jan 2022 09:54:52 +0100 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH] mips/pci: remove redundant ret variable |
| |
On Tue, Jan 04, 2022 at 11:20:24AM +0000, cgel.zte@gmail.com wrote: > From: Minghao Chi <chi.minghao@zte.com.cn> > > Return value from rt3883_pci_r32() directly instead > of taking this in another redundant variable. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> > Signed-off-by: CGEL ZTE <cgel.zte@gmail.com> > --- > arch/mips/pci/pci-rt3883.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/mips/pci/pci-rt3883.c b/arch/mips/pci/pci-rt3883.c > index d3c947fa2969..e07ae098bdd8 100644 > --- a/arch/mips/pci/pci-rt3883.c > +++ b/arch/mips/pci/pci-rt3883.c > @@ -102,14 +102,12 @@ static u32 rt3883_pci_read_cfg32(struct rt3883_pci_controller *rpc, > unsigned func, unsigned reg) > { > u32 address; > - u32 ret; > > address = rt3883_pci_get_cfgaddr(bus, slot, func, reg); > > rt3883_pci_w32(rpc, address, RT3883_PCI_REG_CFGADDR); > - ret = rt3883_pci_r32(rpc, RT3883_PCI_REG_CFGDATA); > > - return ret; > + return rt3883_pci_r32(rpc, RT3883_PCI_REG_CFGDATA); > } > > static void rt3883_pci_write_cfg32(struct rt3883_pci_controller *rpc, > -- > 2.25.1
applied to mips-next.
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |