Messages in this thread | | | Date | Thu, 6 Jan 2022 10:09:46 +0800 | Subject | Re: [PATCH net v3] net/smc: Reset conn->lgr when link group registration fails | From | Wen Gu <> |
| |
Thanks for your suggestion.
On 2022/1/5 9:25 pm, Karsten Graul wrote:
> It might look cleaner with the following changes: > - adopt smc_lgr_cleanup_early() to take only an lgr as parameter and remove the call to smc_conn_free() > - change smc_conn_abort() (which is the only caller of smc_lgr_cleanup_early() right now), always > call smc_conn_free() and if (local_first) additionally call smc_lgr_cleanup_early() > (hold a local copy of the lgr for this call) > - finally call smc_lgr_cleanup_early(lgr) from smc_conn_create() > > This should be the same processing, but the smc_conn_free() is moved to smc_conn_abort() where > it looks to be a better place for this call. And smc_lgr_cleanup_early() takes only care of an lgr. >
I think those are very good changes, making smc_lgr_cleanup_early() processing link group only and more reusable.
> What do you think? Did I miss something? I think it is better and complete. I will improve the patch and test it, then send a v4.
Thanks, Wen Gu
| |