lkml.org 
[lkml]   [2022]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v5 16/21] kvm: x86: Add CPUID support for Intel AMX
Date
> From: Sean Christopherson <seanjc@google.com>
> Sent: Thursday, January 6, 2022 6:29 AM
>
> On Wed, Jan 05, 2022, Yang Zhong wrote:
> > From: Jing Liu <jing2.liu@intel.com>
> >
> > Extend CPUID emulation to support XFD, AMX_TILE, AMX_INT8 and
> > AMX_BF16. Adding those bits into kvm_cpu_caps finally activates all
> > previous logics in this series.
> >
> > Hide XFD on 32bit host kernels. Otherwise it leads to a weird situation
> > where KVM tells userspace to migrate MSR_IA32_XFD and then rejects
> > attempts to read/write the MSR.
> >
> > Signed-off-by: Jing Liu <jing2.liu@intel.com>
> > Signed-off-by: Sean Christopherson <seanjc@google.com>
>
> No need for my SoB, I provided a very tiny snippet of code review.
>

It's not tiny if compared to the rest of the patch, but we certainly can
remove it. anyway thanks for all your suggestions which are all good. 😊
\
 
 \ /
  Last update: 2022-01-06 01:57    [W:0.160 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site