Messages in this thread | | | Date | Tue, 4 Jan 2022 08:48:00 -0400 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v5 00/14] Fix BUG_ON in vfio_iommu_group_notifier() |
| |
On Tue, Jan 04, 2022 at 09:56:30AM +0800, Lu Baolu wrote:
> v5: > - Move kernel dma ownership auto-claiming from driver core to bus > callback. (Greg) > - Refactor the iommu interfaces to make them more specific. > (Jason/Robin) > - Simplify the dma ownership implementation by removing the owner > type. (Jason) > - Commit message refactoring for PCI drivers. (Bjorn) > - Move iommu_attach/detach_device() improvement patches into another > series as there are a lot of code refactoring and cleanup staffs > in various device drivers.
Since you already have the code you should make this 'other series' right now. It should delete iommu_group_attach() and fix iommu_device_attach().
You also didn't really do my suggestion, this messes up the normal __iommu_attach_group()/__iommu_detach_group() instead of adding the clear to purpose iommu_replace_group() for VFIO to use. This just makes it more difficult to normalize the APIs.
Otherwise it does seem to have turned out to be more understandable.
Jason
| |