lkml.org 
[lkml]   [2022]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH misc-next] drivers/misc: remove redundant rc variable
On Tue, Jan 04, 2022 at 11:34:11AM +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value from ocxl_context_attach() directly instead
> of taking this in another redundant variable.

Why? Does this change the compiler output?

>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
> ---
> drivers/misc/ocxl/file.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c
> index e70525eedaae..d881f5e40ad9 100644
> --- a/drivers/misc/ocxl/file.c
> +++ b/drivers/misc/ocxl/file.c
> @@ -74,7 +74,6 @@ static long afu_ioctl_attach(struct ocxl_context *ctx,
> {
> struct ocxl_ioctl_attach arg;
> u64 amr = 0;
> - int rc;
>
> pr_debug("%s for context %d\n", __func__, ctx->pasid);
>
> @@ -86,8 +85,7 @@ static long afu_ioctl_attach(struct ocxl_context *ctx,
> return -EINVAL;
>
> amr = arg.amr & mfspr(SPRN_UAMOR);
> - rc = ocxl_context_attach(ctx, amr, current->mm);
> - return rc;
> + return ocxl_context_attach(ctx, amr, current->mm);
> }
>
> static long afu_ioctl_get_metadata(struct ocxl_context *ctx,
> --
> 2.25.1
>

How did you test this change?

thanks,

greg k-h

\
 
 \ /
  Last update: 2022-01-04 12:45    [W:0.068 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site