lkml.org 
[lkml]   [2022]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] of: unittest: update text of expected warnings
On Thu, 27 Jan 2022 13:26:43 -0600, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> The text of various warning messages triggered by unittest has
> changed. Update the text of expected warnings to match.
>
> The expected vs actual warnings are most easily seen by filtering
> the boot console messages with the of_unittest_expect program at
> https://github.com/frowand/dt_tools.git. The filter prefixes
> problem lines with '***', and prefixes lines that match expected
> errors with 'ok '. All other lines are prefixed with ' '.
> Unrelated lines have been deleted in the following examples.
>
> The mismatch appears as:
>
> -> ### dt-test ### start of unittest - you will see error messages
> OF: /testcase-data/phandle-tests/consumer-a: #phandle-cells = 3 found 1
> ** of_unittest_expect WARNING - not found ---> OF: /testcase-data/phandle-tests/consumer-a: #phandle-cells = 3 found -1
> OF: /testcase-data/phandle-tests/consumer-a: #phandle-cells = 3 found 1
> ** of_unittest_expect WARNING - not found ---> OF: /testcase-data/phandle-tests/consumer-a: #phandle-cells = 3 found -1
> OF: /testcase-data/phandle-tests/consumer-b: #phandle-cells = 2 found 1
> ** of_unittest_expect WARNING - not found ---> OF: /testcase-data/phandle-tests/consumer-b: #phandle-cells = 2 found -1
> platform testcase-data:testcase-device2: error -ENXIO: IRQ index 0 not found
> ** of_unittest_expect WARNING - not found ---> platform testcase-data:testcase-device2: IRQ index 0 not found
> -> ### dt-test ### end of unittest - 254 passed, 0 failed
> ** EXPECT statistics:
> **
> ** EXPECT found : 42
> ** EXPECT not found : 4
>
> With this commit applied, the mismatch is resolved:
>
> -> ### dt-test ### start of unittest - you will see error messages
> ok OF: /testcase-data/phandle-tests/consumer-a: #phandle-cells = 3 found 1
> ok OF: /testcase-data/phandle-tests/consumer-a: #phandle-cells = 3 found 1
> ok OF: /testcase-data/phandle-tests/consumer-b: #phandle-cells = 2 found 1
> ok platform testcase-data:testcase-device2: error -ENXIO: IRQ index 0 not found
> -> ### dt-test ### end of unittest - 254 passed, 0 failed
> ** EXPECT statistics:
> **
> ** EXPECT found : 46
> ** EXPECT not found : 0
>
> Fixes: 2043727c2882 ("driver core: platform: Make use of the helper function dev_err_probe()")
> Fixes: 94a4950a4acf ("of: base: Fix phandle argument length mismatch error message")
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> drivers/of/unittest.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>

Applied, thanks!

\
 
 \ /
  Last update: 2022-01-31 15:37    [W:0.045 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site