lkml.org 
[lkml]   [2022]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 118/200] drm/msm/dsi: Fix missing put_device() call in dsi_get_phy
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    commit c04c3148ca12227d92f91b355b4538cc333c9922 upstream.

    If of_find_device_by_node() succeeds, dsi_get_phy() doesn't
    a corresponding put_device(). Thus add put_device() to fix the exception
    handling.

    Fixes: ec31abf ("drm/msm/dsi: Separate PHY to another platform device")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Link: https://lore.kernel.org/r/20211230070943.18116-1-linmq006@gmail.com
    Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/msm/dsi/dsi.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    --- a/drivers/gpu/drm/msm/dsi/dsi.c
    +++ b/drivers/gpu/drm/msm/dsi/dsi.c
    @@ -40,7 +40,12 @@ static int dsi_get_phy(struct msm_dsi *m

    of_node_put(phy_node);

    - if (!phy_pdev || !msm_dsi->phy) {
    + if (!phy_pdev) {
    + DRM_DEV_ERROR(&pdev->dev, "%s: phy driver is not ready\n", __func__);
    + return -EPROBE_DEFER;
    + }
    + if (!msm_dsi->phy) {
    + put_device(&phy_pdev->dev);
    DRM_DEV_ERROR(&pdev->dev, "%s: phy driver is not ready\n", __func__);
    return -EPROBE_DEFER;
    }

    \
     
     \ /
      Last update: 2022-01-31 12:41    [W:4.064 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site