lkml.org 
[lkml]   [2022]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 029/171] perf/x86/intel/uncore: Fix CAS_COUNT_WRITE issue for ICX
    Date
    From: Zhengjun Xing <zhengjun.xing@linux.intel.com>

    commit 96fd2e89fba1aaada6f4b1e5d25a9d9ecbe1943d upstream.

    The user recently report a perf issue in the ICX platform, when test by
    perf event “uncore_imc_x/cas_count_write”,the write bandwidth is always
    very small (only 0.38MB/s), it is caused by the wrong "umask" for the
    "cas_count_write" event. When double-checking, find "cas_count_read"
    also is wrong.

    The public document for ICX uncore:

    3rd Gen Intel® Xeon® Processor Scalable Family, Codename Ice Lake,Uncore
    Performance Monitoring Reference Manual, Revision 1.00, May 2021

    On 2.4.7, it defines Unit Masks for CAS_COUNT:
    RD b00001111
    WR b00110000

    So corrected both "cas_count_read" and "cas_count_write" for ICX.

    Old settings:
    hswep_uncore_imc_events
    INTEL_UNCORE_EVENT_DESC(cas_count_read, "event=0x04,umask=0x03")
    INTEL_UNCORE_EVENT_DESC(cas_count_write, "event=0x04,umask=0x0c")

    New settings:
    snr_uncore_imc_events
    INTEL_UNCORE_EVENT_DESC(cas_count_read, "event=0x04,umask=0x0f")
    INTEL_UNCORE_EVENT_DESC(cas_count_write, "event=0x04,umask=0x30")

    Fixes: 2b3b76b5ec67 ("perf/x86/intel/uncore: Add Ice Lake server uncore support")
    Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
    Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
    Cc: stable@vger.kernel.org
    Link: https://lkml.kernel.org/r/20211223144826.841267-1-zhengjun.xing@linux.intel.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/x86/events/intel/uncore_snbep.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/events/intel/uncore_snbep.c
    +++ b/arch/x86/events/intel/uncore_snbep.c
    @@ -5482,7 +5482,7 @@ static struct intel_uncore_type icx_unco
    .fixed_ctr_bits = 48,
    .fixed_ctr = SNR_IMC_MMIO_PMON_FIXED_CTR,
    .fixed_ctl = SNR_IMC_MMIO_PMON_FIXED_CTL,
    - .event_descs = hswep_uncore_imc_events,
    + .event_descs = snr_uncore_imc_events,
    .perf_ctr = SNR_IMC_MMIO_PMON_CTR0,
    .event_ctl = SNR_IMC_MMIO_PMON_CTL0,
    .event_mask = SNBEP_PMON_RAW_EVENT_MASK,

    \
     
     \ /
      Last update: 2022-01-31 12:40    [W:3.086 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site