lkml.org 
[lkml]   [2022]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 075/171] i40e: Increase delay to 1 s after global EMP reset
    Date
    From: Jedrzej Jagielski <jedrzej.jagielski@intel.com>

    commit 9b13bd53134c9ddd544a790125199fdbdb505e67 upstream.

    Recently simplified i40e_rebuild causes that FW sometimes
    is not ready after NVM update, the ping does not return.

    Increase the delay in case of EMP reset.
    Old delay of 300 ms was introduced for specific cards for 710 series.
    Now it works for all the cards and delay was increased.

    Fixes: 1fa51a650e1d ("i40e: Add delay after EMP reset for firmware to recover")
    Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
    Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
    Tested-by: Gurucharan G <gurucharanx.g@intel.com>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/intel/i40e/i40e_main.c | 12 +++---------
    1 file changed, 3 insertions(+), 9 deletions(-)

    --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
    +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
    @@ -10574,15 +10574,9 @@ static void i40e_rebuild(struct i40e_pf
    }
    i40e_get_oem_version(&pf->hw);

    - if (test_bit(__I40E_EMP_RESET_INTR_RECEIVED, pf->state) &&
    - ((hw->aq.fw_maj_ver == 4 && hw->aq.fw_min_ver <= 33) ||
    - hw->aq.fw_maj_ver < 4) && hw->mac.type == I40E_MAC_XL710) {
    - /* The following delay is necessary for 4.33 firmware and older
    - * to recover after EMP reset. 200 ms should suffice but we
    - * put here 300 ms to be sure that FW is ready to operate
    - * after reset.
    - */
    - mdelay(300);
    + if (test_and_clear_bit(__I40E_EMP_RESET_INTR_RECEIVED, pf->state)) {
    + /* The following delay is necessary for firmware update. */
    + mdelay(1000);
    }

    /* re-verify the eeprom if we just had an EMP reset */

    \
     
     \ /
      Last update: 2022-01-31 12:22    [W:4.065 / U:3.440 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site