lkml.org 
[lkml]   [2022]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 088/100] yam: fix a memory leak in yam_siocdevprivate()
    Date
    From: Hangyu Hua <hbh25y@gmail.com>

    [ Upstream commit 29eb31542787e1019208a2e1047bb7c76c069536 ]

    ym needs to be free when ym->cmd != SIOCYAMSMCS.

    Fixes: 0781168e23a2 ("yam: fix a missing-check bug")
    Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/hamradio/yam.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
    index 5ab53e9942f30..5d30b3e1806ab 100644
    --- a/drivers/net/hamradio/yam.c
    +++ b/drivers/net/hamradio/yam.c
    @@ -951,9 +951,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
    sizeof(struct yamdrv_ioctl_mcs));
    if (IS_ERR(ym))
    return PTR_ERR(ym);
    - if (ym->cmd != SIOCYAMSMCS)
    - return -EINVAL;
    - if (ym->bitrate > YAM_MAXBITRATE) {
    + if (ym->cmd != SIOCYAMSMCS || ym->bitrate > YAM_MAXBITRATE) {
    kfree(ym);
    return -EINVAL;
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-31 12:17    [W:4.235 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site