lkml.org 
[lkml]   [2022]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 009/100] udf: Restore i_lenAlloc when inode expansion fails
    Date
    From: Jan Kara <jack@suse.cz>

    commit ea8569194b43f0f01f0a84c689388542c7254a1f upstream.

    When we fail to expand inode from inline format to a normal format, we
    restore inode to contain the original inline formatting but we forgot to
    set i_lenAlloc back. The mismatch between i_lenAlloc and i_size was then
    causing further problems such as warnings and lost data down the line.

    Reported-by: butt3rflyh4ck <butterflyhuangxx@gmail.com>
    CC: stable@vger.kernel.org
    Fixes: 7e49b6f2480c ("udf: Convert UDF to new truncate calling sequence")
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/udf/inode.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/udf/inode.c
    +++ b/fs/udf/inode.c
    @@ -316,6 +316,7 @@ int udf_expand_file_adinicb(struct inode
    unlock_page(page);
    iinfo->i_alloc_type = ICBTAG_FLAG_AD_IN_ICB;
    inode->i_data.a_ops = &udf_adinicb_aops;
    + iinfo->i_lenAlloc = inode->i_size;
    up_write(&iinfo->i_data_sem);
    }
    put_page(page);

    \
     
     \ /
      Last update: 2022-01-31 12:06    [W:6.265 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site