lkml.org 
[lkml]   [2022]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] arm64: dts: qcom: sc7280: Clean up sdc1 / sdc2 pinctrl
On Mon 31 Jan 18:25 CST 2022, Doug Anderson wrote:

> Hi,
>
> On Mon, Jan 31, 2022 at 4:11 PM Douglas Anderson <dianders@chromium.org> wrote:
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > index 40cb414bc377..dc98a87e2871 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > @@ -616,6 +616,9 @@ qfprom: efuse@784000 {
> >
> > sdhc_1: sdhci@7c4000 {
> > compatible = "qcom,sc7280-sdhci", "qcom,sdhci-msm-v5";
> > + pinctrl-names = "default", "sleep";
> > + pinctrl-0 = <&sdc1_clk>, <&sdc1_cmd>, <&sdc1_data>, <&sdc1_rclk>;
> > + pinctrl-1 = <&sdc1_clk_sleep>, <&sdc1_cmd_sleep>, <&sdc1_data_sleep>, <&sdc1_rclk_sleep>;
> > status = "disabled";
> >
> > reg = <0 0x007c4000 0 0x1000>,
> > @@ -2425,6 +2428,9 @@ apss_merge_funnel_in: endpoint {
> >
> > sdhc_2: sdhci@8804000 {
> > compatible = "qcom,sc7280-sdhci", "qcom,sdhci-msm-v5";
> > + pinctrl-names = "default", "sleep";
> > + pinctrl-0 = <&sdc2_clk>, <&sdc2_cmd>, <&sdc2_data>;
> > + pinctrl-1 = <&sdc2_clk_sleep>, <&sdc2_cmd_sleep>, <&sdc2_data_sleep>;
> > status = "disabled";
> >
> > reg = <0 0x08804000 0 0x1000>;
> > @@ -3943,81 +3949,76 @@ qup_uart15_rx: qup-uart15-rx {
> > function = "qup17";
> > };
> >
> > - sdc1_on: sdc1-on {
> > - clk {
> > - pins = "sdc1_clk";
> > - };
> >
> > - cmd {
> > - pins = "sdc1_cmd";
> > - };
> >
> > - data {
> > - pins = "sdc1_data";
> > - };
> > + sdc1_clk: sdc1-clk {
>
> Ugh. I just noticed that there are way too many blank lines here in
> the output. Happy to have this fixed when applying or I can post a v2.
>

I can fix that up as I apply it. Will let it sit for a few days to
attract reviews first though.

Regards,
Bjorn

\
 
 \ /
  Last update: 2022-02-01 01:33    [W:0.062 / U:1.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site