lkml.org 
[lkml]   [2022]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v9 04/23] securityfs: Extend securityfs with namespacing support
From
Date
On Mon, 2022-01-31 at 17:28 -0500, Stefan Berger wrote:
> On 1/27/22 11:53, Mimi Zohar wrote:
> > On Tue, 2022-01-25 at 17:46 -0500, Stefan Berger wrote:
> >> From: Stefan Berger <stefanb@linux.ibm.com>
> >>
> >> Enable multiple instances of securityfs by keying each instance with a
> >> pointer to the user namespace it belongs to.
> >>
> >> Since we do not need the pinning of the filesystem for the virtualization
> >> case, limit the usage of simple_pin_fs() and simpe_release_fs() to the
> >> case when the init_user_ns is active. This simplifies the cleanup for the
> >> virtualization case where usage of securityfs_remove() to free dentries
> >> is not needed anymore.
> > Could you add a sentence here explaining why securityfs_remove() isn't
> > needed in the virtualization case?
>
> At this point the reason is that simple_pin_fs() is not used for the
> virtualization case.
>
> Maybe it should say: ... to free dentries is *therefore* not needed anymore.

Probably it's obvious, but I was looking for something along the lines
of, "The securityfs file or directory is automatically removed based on
reference count."

No need to update it.

thanks,

Mimi

\
 
 \ /
  Last update: 2022-02-01 00:45    [W:0.085 / U:1.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site