Messages in this thread | | | Date | Tue, 1 Feb 2022 08:37:57 +1300 | From | Paulo Miguel Almeida <> | Subject | Re: [PATCH v3] staging: pi433: add debugfs interface |
| |
On Mon, Jan 31, 2022 at 04:45:58PM +0300, Dan Carpenter wrote: > On Sun, Jan 30, 2022 at 03:57:26PM +1300, Paulo Miguel Almeida wrote: > > + dev = m->private; > > + > > + mutex_lock(&dev->tx_fifo_lock); > > + mutex_lock(&dev->rx_lock); > > + > > + // wait for on-going operations to finish > > + ret = wait_event_interruptible(dev->rx_wait_queue, !dev->tx_active); > > + if (ret) > > + return ret; > > Drop the two mutexes before returning. >
thanks for taking the time for reviewing this patch.
good catch, I completely missed it. Thanks a lot!
thanks,
Paulo Almeida
| |