Messages in this thread | | | Date | Tue, 1 Feb 2022 08:30:32 +1300 | From | Paulo Miguel Almeida <> | Subject | Re: [PATCH] staging: pi433: remove unnecessary new line escape sequence characters |
| |
On Mon, Jan 31, 2022 at 01:40:20PM +0300, Dan Carpenter wrote: > > if (device->irq_state[DIO0] == DIO_PACKET_SENT) { > > device->free_in_fifo = FIFO_SIZE; > > - dev_dbg(device->dev, "DIO0 irq: Packet sent\n"); > > + dev_dbg(device->dev, "DIO0 irq: Packet sent"); > > Both the old and new code will do the same thing. You are correct. > However in terms of style, I believe the preference is to add a newline. > > I don't remember the reasoning behind this. But a lot of these style > rules are just decided by consensus. If you do a > `git grep -w dev_dbg | grep \;$` then it is 12391 places that add a > new line and 622 which don't. Adding a newline is the clear winner. >
it makes sense. I will send a different patch adding the newline escapes instead.
Thanks heaps!
Paulo Almeida
| |