Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 31 Jan 2022 19:30:48 +0100 | Subject | Re: [PATCH net-next] net: kbuild: Don't default net vendor configs to y |
| |
On Mon, Jan 31, 2022 at 6:59 PM Stephen Hemminger <stephen@networkplumber.org> wrote: > On Mon, 31 Jan 2022 09:24:50 -0800 > Saeed Mahameed <saeed@kernel.org> wrote: > > > From: Saeed Mahameed <saeedm@nvidia.com> > > > > NET_VENDOR_XYZ were defaulted to 'y' for no technical reason. > > > > Since all drivers belonging to a vendor are supposed to default to 'n', > > defaulting all vendors to 'n' shouldn't be an issue, and aligns well > > with the 'no new drivers' by default mentality. > > > > Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> > > This was done back when vendors were introduced in the network drivers tree. > The default of Y allowed older configurations to just work.
And changing the defaults means all defconfigs must be updated first, else the user's configs will end up without drivers needed.
> So there was a reason, not sure if it matters anymore. > But it seems like useless repainting to change it now.
It might make sense to tune some of the defaults (i.e. change to "default y if ARCH_*") for drivers with clear platform dependencies.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |