lkml.org 
[lkml]   [2022]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 07/16] tools/include: Add io.h stub
On Mon, Jan 31, 2022 at 4:18 PM Mike Rapoport <rppt@kernel.org> wrote:
> On Mon, Jan 31, 2022 at 02:30:32PM +0100, Arnd Bergmann wrote:
> > On Sun, Jan 30, 2022 at 6:53 PM Matthew Wilcox <willy@infradead.org> wrote:

> I actually liked m68k's name for a header with virt_to_phys/phys_to_virt
> definitions - virtconvert.h.
>
> As an experiment I pulled out address translations from
> arch/arm/include/memory.h to arch/arm/include/virtconvert.h, it wasn't that
> bad:
>
> arch/arm/include/asm/dma-mapping.h | 2 +
> arch/arm/include/asm/io.h | 1 +
> arch/arm/include/asm/memory.h | 244 ----------------------------------
> arch/arm/include/asm/pgtable.h | 1 +
> arch/arm/include/asm/virtconvert.h | 264 +++++++++++++++++++++++++++++++++++++
> arch/arm/kernel/psci_smp.c | 1 +
> 6 files changed, 269 insertions(+), 244 deletions(-)
>
> (https://git.kernel.org/rppt/linux/c/4c34ec16319fc85280aad89d7a74df845c1614fc)

Right, that doesn't look too bad, especially since it seems you managed to avoid
any further indirect inlcudes. Doing the same consistently for all architectures
may end up a bit harder but would be a great help.

Arnd

\
 
 \ /
  Last update: 2022-01-31 17:29    [W:0.055 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site