Messages in this thread | | | Date | Mon, 31 Jan 2022 16:22:19 +0100 | Subject | Re: [PATCH v4 18/20] extcon: intel-cht-wc: Refactor cht_wc_extcon_get_charger() | From | Hans de Goede <> |
| |
Hi,
On 1/31/22 14:56, Andy Shevchenko wrote: > On Sun, Jan 30, 2022 at 09:45:55PM +0100, Hans de Goede wrote: >> This is a preparation patch for adding support for registering >> a power_supply class device. >> >> Setting usbsrc to "CHT_WC_USBSRC_TYPE_SDP << CHT_WC_USBSRC_TYPE_SHIFT" >> will make the following switch-case return EXTCON_CHG_USB_SDP >> just as before, so there is no functional change. > > ... > >> - return EXTCON_CHG_USB_SDP; /* Save fallback */ > >> + /* Save fallback */ > > I see it's in the previous code, but what does it mean? > I would read it as "Safe fallback", bit I have no clue.
Ah yes that should be safe not save, sorry will fix for v5.
Regards,
Hans
| |