lkml.org 
[lkml]   [2022]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fs: Remove FIXME comment in generic_write_checks()
On Fri, Dec 31, 2021 at 02:57:50AM -0500, Tal Zussman wrote:
> This patch removes an unnecessary comment that had to do with block special
> files from `generic_write_checks()`.
>
> The comment, originally added in Linux v2.4.14.9, was to clarify that we only
> set `pos` to the file size when the file was opened with `O_APPEND` if the file
> wasn't a block special file. Prior to Linux v2.4, block special files had a
> different `write()` function which was unified into a generic `write()` function
> in Linux v2.4. This generic `write()` function called `generic_write_checks()`.
> For more details, see this earlier conversation:
> https://lore.kernel.org/linux-fsdevel/Yc4Czk5A+p5p2Y4W@mit.edu/
>
> Currently, block special devices have their own `write_iter()` function and no
> longer share the same `generic_write_checks()`, therefore rendering the comment
> irrelevant.

Applied

\
 
 \ /
  Last update: 2022-01-30 20:36    [W:0.051 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site