lkml.org 
[lkml]   [2022]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v16, 2/2] net: Add dm9051 driver
On Sun, Jan 30, 2022 at 12:43:46AM +0800, Joseph CHAMG wrote:
> Add davicom dm9051 spi ethernet driver, The driver work for the
> device platform which has the spi master
>
> Signed-off-by: Joseph CHAMG <josright123@gmail.com>
> ---
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: andy Shevchenko <andy.shevchenko@gmail.com>

<...>

> +static int dm9051_probe(struct spi_device *spi)
> +{
> + struct device *dev = &spi->dev;
> + struct net_device *ndev;
> + struct board_info *db;
> + int ret = 0;

<...>

> + kthread_init_worker(&db->kw);
> + kthread_init_work(&db->kw_rxctrl, dm9051_rxctl_delay);
> + kthread_init_work(&db->kw_tx, dm9051_tx_delay);
> +
> + db->kwr_task_kw = kthread_run(kthread_worker_fn, &db->kw, "dm9051");

It is very unlikely that simple driver like this will need kthreads, does it really need?

Thanks

\
 
 \ /
  Last update: 2022-01-30 19:37    [W:0.075 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site